linux-kernel - Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABXAfNJSpttL=jGL1CwQ0CWQis_zEiXMTedcujZb7vcZEJtDmQ@mail.gmail.com>
Date:	Sun, 25 Oct 2015 14:47:56 +0530
From:	punit vara <punitvara@...il.com>
To:	"Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
Cc:	JBottomley@...n.com, don.brace@...s.com, storagedev@...s.com,
	iss_storagedev@...com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

On Sat, Oct 24, 2015 at 4:56 AM, Matthew R. Ochs
<mrochs@...ux.vnet.ibm.com> wrote:
> Hi Punit,
>
> Aren't you missing the removal of the memset() as part of this conversion?
>
>
> -matt
>
>> On Oct 23, 2015, at 3:03 PM, Punit Vara <punitvara@...il.com> wrote:
>>
>> This patch is to the lpfc_els.c which resolves following warning
>> reported by coccicheck:
>>
>> WARNING: kzalloc should be used for rdp_context, instead of
>> kmalloc/memset
>>
>> Signed-off-by: Punit Vara <punitvara@...il.com>
>> ---
>> drivers/scsi/lpfc/lpfc_els.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
>> index 36bf58b..422c800 100644
>> --- a/drivers/scsi/lpfc/lpfc_els.c
>> +++ b/drivers/scsi/lpfc/lpfc_els.c
>> @@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>>       if (RDP_NPORT_ID_SIZE !=
>>                       be32_to_cpu(rdp_req->nport_id_desc.length))
>>               goto rjt_logerr;
>> -     rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>> +     rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>>       if (!rdp_context) {
>>               rjt_err = LSRJT_UNABLE_TPC;
>>               goto error;
>
Thanks for reviewing my patches.
Can I send more patches ? my all previous patches already reviewed by
you . Should I wait to apply this patch to tree or i can send new
patch set ? Please suggest me sir.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/