[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXu5j+n4KB1Ld8i5N6jCCRU8bp7D+eHw3xL6B4t6k6RoqSMTg@mail.gmail.com>
Date: Mon, 26 Oct 2015 15:39:30 +0900
From: Kees Cook <keescook@...omium.org>
To: Rasmus Villemoes <linux@...musvillemoes.dk>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/13] lib/test_printf.c: don't BUG
On Wed, Oct 21, 2015 at 5:30 AM, Rasmus Villemoes
<linux@...musvillemoes.dk> wrote:
> BUG is a completely unnecessarily big hammer, and we're more likely to
> get the internal bug reported if we just pr_err() and ensure the test
> suite fails.
>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
Acked-by: Kees Cook <keescook@...omium.org>
-Kees
> ---
> lib/test_printf.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index c5a666af9ba5..9232a2add28c 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -91,7 +91,12 @@ __test(const char *expect, int elen, const char *fmt, ...)
> int rand;
> char *p;
>
> - BUG_ON(elen >= BUF_SIZE);
> + if (elen >= BUF_SIZE) {
> + pr_err("error in test suite: expected output length %d too long. Format was '%s'.\n",
> + elen, fmt);
> + failed_tests++;
> + return;
> + }
>
> va_start(ap, fmt);
>
> --
> 2.6.1
>
--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists