linux-kernel - Re: [PATCH 10/13] lib/test_printf.c: account for kvasprintf tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Oct 2015 15:43:59 +0900
From:	Kees Cook <keescook@...omium.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/13] lib/test_printf.c: account for kvasprintf tests

On Wed, Oct 21, 2015 at 5:30 AM, Rasmus Villemoes
<linux@...musvillemoes.dk> wrote:
> These should also count as performed tests.
>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  lib/test_printf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 80ddafb2675d..8fca007d9bcd 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -127,6 +127,7 @@ __test(const char *expect, int elen, const char *fmt, ...)
>
>         p = kvasprintf(GFP_KERNEL, fmt, ap);
>         if (p) {
> +               total_tests++;
>                 if (memcmp(p, expect, elen+1)) {
>                         pr_warn("kvasprintf(..., \"%s\", ...) returned '%s', expected '%s'\n",
>                                 fmt, p, expect);
> --
> 2.6.1
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/