lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8217156.HJH9oYGKMG@avalon> Date: Mon, 26 Oct 2015 03:20:36 +0200 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Julia Lawall <Julia.Lawall@...6.fr> Cc: Hyun Kwon <hyun.kwon@...inx.com>, kernel-janitors@...r.kernel.org, Mauro Carvalho Chehab <mchehab@....samsung.com>, Michal Simek <michal.simek@...inx.com>, Sören Brinkmann <soren.brinkmann@...inx.com>, linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Russell King - ARM Linux <linux@....linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Andrew Lunn <andrew@...n.ch>, Bjorn Helgaas <bhelgaas@...gle.com>, Jason Cooper <jason@...edaemon.net> Subject: Re: [PATCH 5/8] [media] v4l: xilinx-vipp: add missing of_node_put Hi Julia, Thank you for the patch. On Sunday 25 October 2015 14:57:04 Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > > + of_node_put(child); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> > --- > drivers/media/platform/xilinx/xilinx-vipp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c > b/drivers/media/platform/xilinx/xilinx-vipp.c index 7b7cb9c..b9bf24f 100644 > --- a/drivers/media/platform/xilinx/xilinx-vipp.c > +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > @@ -476,8 +476,10 @@ static int xvip_graph_dma_init(struct > xvip_composite_device *xdev) > > for_each_child_of_node(ports, port) { > ret = xvip_graph_dma_init_one(xdev, port); > - if (ret < 0) > + if (ret < 0) { > + of_node_put(port); > return ret; > + } > } > > return 0; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists