linux-kernel - Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562E0E18.80500@metafoo.de>
Date:	Mon, 26 Oct 2015 12:27:20 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
CC:	alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

On 10/24/2015 11:37 PM, Robert Jarzmik wrote:
[...]
> -static unsigned int ac97_read(struct snd_soc_codec *codec,
> -	unsigned int reg);
> -static int ac97_write(struct snd_soc_codec *codec,
> -	unsigned int reg, unsigned int val);

For review purposes it would be helpful to split this into two patches. One
performing the regmap conversion the other replacing
ac97_read()/ac97_write() with the matching snd_soc_ calls (or
snd_soc_update_bits).

> +	snd_soc_codec_init_regmap(codec, regmap);

You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/