lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2015 11:15:57 +0800 From: Jason Wang <jasowang@...hat.com> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevic@...hat.com> Subject: Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote: > On Fri, Oct 23, 2015 at 12:57:05AM -0400, Jason Wang wrote: >> We don't have fraglist support in TAP_FEATURES. This will lead >> software segmentation of gro skb with frag list. Fixes by having >> frag list support in TAP_FEATURES. >> >> With this patch single session of netperf receiving were restored from >> about 5Gb/s to about 12Gb/s on mlx4. >> >> Fixes a567dd6252 ("macvtap: simplify usage of tap_features") >> Cc: Vlad Yasevich <vyasevic@...hat.com> >> Cc: Michael S. Tsirkin <mst@...hat.com> >> Signed-off-by: Jason Wang <jasowang@...hat.com> > Thanks! > Does this mean we should look at re-adding NETIF_F_FRAGLIST > to virtio-net as well? Not sure I get the point, but probably not. This is for receiving and skb_copy_datagram_iter() can deal with frag list. > >> --- >> drivers/net/macvtap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c >> index 248478c..197c939 100644 >> --- a/drivers/net/macvtap.c >> +++ b/drivers/net/macvtap.c >> @@ -137,7 +137,7 @@ static const struct proto_ops macvtap_socket_ops; >> #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \ >> NETIF_F_TSO6 | NETIF_F_UFO) >> #define RX_OFFLOADS (NETIF_F_GRO | NETIF_F_LRO) >> -#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG) >> +#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG | NETIF_F_FRAGLIST) >> >> static struct macvlan_dev *macvtap_get_vlan_rcu(const struct net_device *dev) >> { >> -- >> 1.8.3.1 > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists