linux-kernel - Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562E42FB.6030600@amd.com>
Date:	Mon, 26 Oct 2015 10:12:59 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<tony.luck@...el.com>, <x86@...nel.org>, <ashok.raj@...el.com>,
	<linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<peterz@...radead.org>, <luto@...nel.org>, <dvlasenk@...hat.com>,
	<ross.zwisler@...ux.intel.com>, <dirk.j.brandewie@...el.com>,
	Wan Zongshun <Vincent.Wan@....com>
Subject: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature

On 10/25/2015 5:37 AM, Borislav Petkov wrote:
> On Fri, Oct 23, 2015 at 06:18:33AM -0500, Aravind Gopalakrishnan wrote:
>> CLZERO instruction introduced in AMD Fam17h processors
>> zero's out a 64 byte cache line specified in RAX.
>>
>> Add the bit here to allow /proc/cpuinfo to list the feature
>>
>> Signed-off-by: Wan Zongshun <Vincent.Wan@....com>
>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
> This SOB chain looks wrong - if Vincent is the author and you're only
> sending the patch, then his "From:" needs to appear before the commit
> message. git send-email does that correctly, provided the authorship is
> correctly set in the local branch you're sending the patch from.

For large part yes, wrapped code in patch form with commit message etc.
And modified comment a little bit.

Does that still require his address in "From"?

>>   
>>   /*
>> @@ -255,6 +255,9 @@
>>   /* Intel-defined CPU QoS Sub-leaf, CPUID level 0x0000000F:1 (edx), word 12 */
>>   #define X86_FEATURE_CQM_OCCUP_LLC (12*32+ 0) /* LLC occupancy monitoring if 1 */
>>   
>> +/* AMD extended feature extension, CPUID level 0x80000008 (ebx), word 13 */
> extended ... extension sounds like a tautology, please sanitize.

Haha. True. But looks like that's actually it's name.

If tautologies are not your thing, how about changing comments around 
0x80000001,ecx to say "AMD extended features 1" and
for 0x80000008, ebx say "AMD extended features 2"?

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/