linux-kernel - Re: [PATCH 1/1] x86: Fix reading the current exposure value of UVC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23322093.WD04LuM9l7@avalon>
Date:	Mon, 26 Oct 2015 05:25:40 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	"Anton V. Shokurov" <shokurov.anton.v@...dex.ru>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86: Fix reading the current exposure value of UVC

Hi Anton,

Thank you for the patch.

On Sunday 18 October 2015 17:01:26 Anton V. Shokurov wrote:
> V4L2_CID_EXPOSURE_ABSOLUTE property does not return an updated value when
> autoexposure (V4L2_CID_EXPOSURE_AUTO) is turned on. This patch fixes this
> issue by adding the UVC_CTRL_FLAG_AUTO_UPDATE flag.
> 
> Tested on a C920 camera.

This looks good to me and I've successfully tested the patch.

> Signed-off-by: Anton V. Shokurov <shokurov.anton.v@...dex.ru>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Applied to my tree, I'll push it upstream for v4.5 (the merge window for v4.4 
will open in a week only and with the Kernel Summit going on this week pushing 
patches for v4.4 is difficult).

> ---
>  drivers/media/usb/uvc/uvc_ctrl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c
> b/drivers/media/usb/uvc/uvc_ctrl.c index 3e59b28..c2ee6e3 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -227,7 +227,8 @@ static struct uvc_control_info uvc_ctrls[] = {
>  		.size		= 4,
>  		.flags		= UVC_CTRL_FLAG_SET_CUR
> 
>  				| UVC_CTRL_FLAG_GET_RANGE
> 
> -				| UVC_CTRL_FLAG_RESTORE,
> +				| UVC_CTRL_FLAG_RESTORE
> +				| UVC_CTRL_FLAG_AUTO_UPDATE,
>  	},
>  	{
>  		.entity		= UVC_GUID_UVC_CAMERA,

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/