linux-kernel - Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1445878268.20657.91.camel@hpe.com>
Date:	Mon, 26 Oct 2015 10:51:08 -0600
From:	Toshi Kani <toshi.kani@....com>
To:	"Luck, Tony" <tony.luck@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error
 injection to NVDIMM

On Mon, 2015-10-26 at 16:46 +0000, Luck, Tony wrote:
> > +           ((param2 & PAGE_MASK) != PAGE_MASK))
> >                return -EINVAL;
> > 
> > The 3rd condition check makes sure that the param2 mask is the page size or less.  So, 
> > I think we are OK on this.
> 
> Oops. The original was even on the screen as part of the diff (which I signed off on
> just two years ago).
> 
> I'd be happier if you made it the 1st condition though, so we skip calling 
> region_intersects_*() with a nonsense "size" argument.

Agreed.  I will send an updated patch 3/3 later today, "[PATCH v2 UPDATE-2 3/3]".

Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/