linux-kernel - Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <562E9E03.1080509@labbott.name>
Date:	Mon, 26 Oct 2015 14:41:23 -0700
From:	Laura Abbott <laura@...bott.name>
To:	Dzonatans Melgalvis <dz.melgalvis@...il.com>,
	gregkh@...uxfoundation.org
Cc:	arve@...roid.com, riandrews@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: uapi: fixed comment block coding style
 error in ion.h

On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
>

The right aligned comments aren't great style.
How about moving the comments (with the correct style) right
above the macro they are describing.

> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@...il.com>
> ---
>   drivers/staging/android/uapi/ion.h | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 68a14b4..11df59f 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -56,13 +56,15 @@ enum ion_heap_type {
>    * allocation flags - the lower 16 bits are used by core ion, the upper 16
>    * bits are reserved for use by the heaps themselves.
>    */
> -#define ION_FLAG_CACHED 1		/* mappings of this buffer should be
> -					   cached, ion will do cache
> -					   maintenance when the buffer is
> -					   mapped for dma */
> +#define ION_FLAG_CACHED 1		/*  mappings of this buffer should be
> +					 *  cached, ion will do cache
> +					 *  maintenance when the buffer is
> +					 *  mapped for dma
> +					 */
>   #define ION_FLAG_CACHED_NEEDS_SYNC 2	/* mappings of this buffer will created
> -					   at mmap time, if this is set
> -					   caches must be managed manually */
> +					 *  at mmap time, if this is set
> +					 *  caches must be managed manually
> +					 */
>
>   /**
>    * DOC: Ion Userspace API
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/