[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151026222148.GA10647@gmail.com>
Date: Mon, 26 Oct 2015 23:21:48 +0100
From: Bogicevic Sasa <brutallesale@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues
On 10/26, Bogicevic Sasa wrote:
>Thanks for the review just sent the new patch,
>since change is very trivial I believe one liner like "fix all coding
>style issues in that and that file" is descriptive enough. Don't know the
>best practice so please be patient, I am new at this
>On 10/27, Greg KH wrote:
>>On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote:
>>>Fixed coding style issues
>>>Signed-off-by: Bogicevic Sasa <brutallesale@...il.com>
>>
>>What code style issues? Please be very specific. Also be sure you are
>>only doing one "thing" per patch, and no, "fix all coding style issues"
>>is not one thing...
>>
>>And we need a blank line before your signed-off-by: line.
>>
>>thanks,
>>
>>greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists