linux-kernel - Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562EAE47.2080100@amd.com>
Date:	Mon, 26 Oct 2015 17:50:47 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<tony.luck@...el.com>, <x86@...nel.org>, <ashok.raj@...el.com>,
	<linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<peterz@...radead.org>, <luto@...nel.org>, <dvlasenk@...hat.com>,
	<ross.zwisler@...ux.intel.com>, <dirk.j.brandewie@...el.com>,
	Wan Zongshun <Vincent.Wan@....com>
Subject: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature

On 10/26/2015 3:22 PM, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 10:12:59AM -0500, Aravind Gopalakrishnan wrote:
>> For large part yes, wrapped code in patch form with commit message etc.
>> And modified comment a little bit.
>>
>> Does that still require his address in "From"?
> Yes, because it sounds like he was the author of the original patch.

Okay, will fix that in V2.

> No, I think you should add that bit to init_scattered_cpuid_features()
> instead.
>
> And btw, those Intel QoS single bit defines and the XSAVE stuff there
> should move to that function too - that's a pure waste having them in
> the cap_flags array. I'll fix that.
>

Ok, I added it to init_scattered_cpuid_features() on top of your RFC 
patch and it seems to work fine.

How do you prefer a V2 for this to be sent though-
Shall I wait until your fixes are in tip.git and resend?
Or send a V2 on top of current tip.git?

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/