[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151027225934.GL22331@piout.net>
Date: Tue, 27 Oct 2015 23:59:34 +0100
From: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To: Alim Akhtar <alim.akhtar@...sung.com>
Cc: lee.jones@...aro.org, broonie@...nel.org, k.kozlowski@...sung.com,
mturquette@...libre.com, linux-samsung-soc@...r.kernel.org,
linux-clk@...r.kernel.org, rtc-linux@...glegroups.com,
linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support
for S2MPS15 RTC
On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote :
> RTC found in s2mps15 is almost same as one found in s2mps14.
> This patch add required changes to enable s2mps15 rtc timer.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
One really small nitpick below else you can add my
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
> drivers/rtc/rtc-s5m.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> @@ -317,7 +319,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm)
> u8 data[info->regs->regs_count];
> int ret;
>
> - if (info->device_type == S2MPS14X || info->device_type == S2MPS13X) {
> + if (info->device_type == S2MPS14X || info->device_type == S2MPS15X ||
> + info->device_type == S2MPS13X) {
This line is not properly aligned.
> ret = regmap_update_bits(info->regmap,
> info->regs->rtc_udr_update,
> S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK);
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists