linux-kernel - Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2015 15:02:09 +0900
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mans Rullgard <mans@...sr.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	slash.tmp@...e.fr
Subject: Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800
 Ethernet controller


> +
> +static struct ethtool_ops nb8800_ethtool_ops = {
Ops should be const

> +	.get_settings		= nb8800_get_settings,
> +	.set_settings		= nb8800_set_settings,
> +	.nway_reset		= nb8800_nway_reset,
> +	.get_link		= ethtool_op_get_link,
> +};
> +

Since you are implementing ethtool please add a driver
info function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/