| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1445931626-11158-1-git-send-email-peter.chen@freescale.com> Date: Tue, 27 Oct 2015 15:40:25 +0800 From: Peter Chen <peter.chen@...escale.com> To: <jbaron@...mai.com> CC: <corbet@....net>, <linux-kernel@...r.kernel.org>, Peter Chen <peter.chen@...escale.com>, <stable@...r.kernel.org> Subject: [PATCH 1/2] dynamic_debug: fix boot parameters parse The parse_args will delete space between boot parameters, so if we add dyndbg="file drivers/usb/* +p" at bootargs, the parse_args will split it as three parameters, and only "file" is for dyndbg, then below error will occur at ddebug, it causes all non-module ddebug fail during the boot process. =============================================================== dynamic_debug:ddebug_parse_flags: bad flag-op f, at start of file dynamic_debug:ddebug_exec_query: flags parse failed =============================================================== As a solution, we can use comma to split parameters for ddebug booting parameter, and replace comma with space at code, in that case, the ddebug core can handle it with the same way we do it for /sys. Signed-off-by: Peter Chen <peter.chen@...escale.com> Cc: <stable@...r.kernel.org> --- lib/dynamic_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index e491e02..da4883b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -880,6 +880,8 @@ static int ddebug_dyndbg_param_cb(char *param, char *val, if (strcmp(param, "dyndbg")) return on_err; /* determined by caller */ + /* relace comma with space */ + strreplace(val, ',', ' '); ddebug_exec_queries((val ? val : "+p"), modname); return 0; /* query failure shouldnt stop module load */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists