linux-kernel - Re: [PATCH -next] gpio: generic: Revert to old error handling in bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY_G21Kh3bQDQ=Zz3PxgQnGSiKyow133dQzJWTq2LcJNw@mail.gmail.com>
Date:	Tue, 27 Oct 2015 11:28:07 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH -next] gpio: generic: Revert to old error handling in bgpio_map

On Wed, Oct 21, 2015 at 9:12 AM, Guenter Roeck <linux@...ck-us.net> wrote:

> Returning an error instead of NULL in bgpio_map if
> platform_get_resource_byname does not find a resource was introduced with
> commit cf3f2a2c8bae ("gpio: generic: improve error handling in bgpio_map").
> This results in several qemu runtime failures with default and non-default
> configurations, if attempts are made to boot from mmcblk0. Examples for
> failures with multi_v7_defconfig are
>
> Machine: vexpress-a9    dtb: vexpress-v2p-ca9
> Machine: vexpress-a15   dtb: vexpress-v2p-ca15-tc1
>
> Crash:
>
> VFS: Cannot open root device "mmcblk0" or unknown-block(0,0): error -6
> Please append a correct "root=" boot option; here are the available partitions:
> Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
>
> Looking into the code, always returning an error if bgpio_map fails
> does not appear to make much sense, since the code in bgpio_setup_io
> specifically supports some of the resources to be NULL.
>
> Fixes: cf3f2a2c8bae ("gpio: generic: improve error handling in bgpio_map")
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Patch/revert applied. Thanks for digging in and fixing this Günther!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/