linux-kernel - Re: [PATCH] Staging:drivers:wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151027111201.GA5033@gmail.com>
Date:	Tue, 27 Oct 2015 12:12:01 +0100
From:	Bogicevic Sasa <brutallesale@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues

Thanks, I get it now, Ill will group all changes and resend the patches
On 10/27/2015, Greg KH wrote:
>On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote:
>> On 10/26, Bogicevic Sasa wrote:
>> >Thanks for the review just sent the new patch,
>> >since change is very trivial I believe one liner like "fix all coding
>> >style issues in that and that file" is descriptive enough.
>
>No, not at all, that's not how we make kernel changes, look in the logs
>for specifics.  Each patch needs to be descriptive and only do one
>thing.  And as I said before "fix all coding style issues", is _NOT_
>"one thing".
>
>Please break it up into logical patches, _AND_ use checkpatch.pl to
>properly send the patches to the correct mailing list and developers.
>
>thanks,
>
>greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/