linux-kernel - Re: [PATCH v4 0/7] USB MIDI Gadget improvements and bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <562F86CC.4070305@felipetonello.com>
Date:	Tue, 27 Oct 2015 14:14:36 +0000
From:	Felipe Ferreri Tonello <eu@...ipetonello.com>
To:	linux-usb@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH v4 0/7] USB MIDI Gadget improvements and bug fixes

Hi Balbi,

On 26/10/15 16:55, Felipe F. Tonello wrote:
> Patch 7 has changes on how to transmit IN USB requests. It implements a FIFO
> of pre-allocated usb requests and uses then as needed, instead of allocating
> then on demand. This is my initial implementation and is open for
> suggestions and comments.
> 
> Patches 1-6 is pretty much straight forward.
> 
> changes in v4:
>  - pre-alocation of in requests.
>  - more code clean up
>  - fix memory leak on out requests
>  - configure endpoints only when setting up MIDIStreaming interface
> 
> Felipe F. Tonello (7):
>   usb: gadget: f_midi: Transmit data only when IN ep is enabled
>   usb: gadget: f_midi: remove duplicated code
>   usb: gadget: define free_ep_req as universal function
>   usb: gadget: f_midi: fix leak on failed to enqueue out requests
>   usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
>   usb: gadget: gmidi: Cleanup legacy code
>   usb: gadget: f_midi: pre-allocate IN requests
> 
>  drivers/usb/gadget/function/f_midi.c       | 201 ++++++++++++++++++++---------
>  drivers/usb/gadget/function/f_sourcesink.c |   6 -
>  drivers/usb/gadget/function/g_zero.h       |   1 -
>  drivers/usb/gadget/legacy/gmidi.c          |  12 +-
>  drivers/usb/gadget/u_f.c                   |   8 ++
>  drivers/usb/gadget/u_f.h                   |   3 +-
>  6 files changed, 151 insertions(+), 80 deletions(-)
> 

I have rebased this patchset on top of your next branch. It removes the
need for patch 1 and patch 5.

I am waiting for more comments on other patches to fix things if needed
before sending v5.

-- 
Felipe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/