linux-kernel - Re: [PATCH] w1: w1_process() is not freezable kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2428911445956236@web17h.yandex.ru>
Date:	Tue, 27 Oct 2015 17:30:36 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	GregKH <greg@...ah.com>
Subject: Re: [PATCH] w1: w1_process() is not freezable kthread

Hi

26.10.2015, 08:53, "Jiri Kosina" <jikos@...nel.org>:
> From: Jiri Kosina <jkosina@...e.cz>
>
> w1_process() calls try_to_freeze(), but the thread doesn't mark itself
> freezable through set_freezable(), so the try_to_freeze() call is useless.

I believe it is better to mark it freezable, what do you think?
Its task is useless if anyone else goes sleeping, it should freeze too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/