linux-kernel - Re: [PATCH 1/3] ibmvsci: make parameters max_id and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562F9A6F.2000201@redhat.com>
Date:	Tue, 27 Oct 2015 16:38:23 +0100
From:	Laurent Vivier <lvivier@...hat.com>
To:	"James E.J. Bottomley" <JBottomley@...n.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>, dgibson@...hat.com,
	thuth@...hat.com, pbonzini@...hat.com
Subject: Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel
 read-only

Ping ?

On 13/10/2015 23:23, Laurent Vivier wrote:
> James,
> 
> this series has been reviewed and ack'ed,
> as SCSI maintainer, could you take it ?
> 
> Laurent
> 
> On 10/09/2015 11:23, Laurent Vivier wrote:
>> The value of the parameter is never re-read by the driver,
>> so a new value is ignored. Let know the user he
>> can't modify it by removing writable attribute.
>>
>> Signed-off-by: Laurent Vivier <lvivier@...hat.com>
>> ---
>> I resend this patch as James was not cc'ed.
>>
>>  drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
>> index 6a41c36..3e76490 100644
>> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
>> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
>> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
>>  MODULE_LICENSE("GPL");
>>  MODULE_VERSION(IBMVSCSI_VERSION);
>>  
>> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
>> +module_param_named(max_id, max_id, int, S_IRUGO);
>>  MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
>> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
>> +module_param_named(max_channel, max_channel, int, S_IRUGO);
>>  MODULE_PARM_DESC(max_channel, "Largest channel value");
>>  module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
>>  MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/