linux-kernel - Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151027021250.GR28319@sirena.org.uk>
Date:	Tue, 27 Oct 2015 11:12:50 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Heiko Schocher <hs@...x.de>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator

On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
> add DT support for the tps6502x regulators.

Please use subject lines matching the style for the subsystem.

> +	regulators = of_get_child_by_name(np, "regulators");
> +	if (!regulators) {
> +		dev_err(dev, "regulator node not found\n");
> +		return NULL;
> +	}

Please use the generic support for locating the DT information for
regulators using regulators_node and of_match in the regulator_desc
rather than open coding this.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)