[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <562FAA88.3020609@linaro.org>
Date: Tue, 27 Oct 2015 17:47:04 +0100
From: Tomasz Nowicki <tomasz.nowicki@...aro.org>
To: Tomasz Nowicki <tn@...ihalf.com>, bhelgaas@...gle.com,
arnd@...db.de, will.deacon@....com, catalin.marinas@....com,
rjw@...ysocki.net, hanjun.guo@...aro.org, Lorenzo.Pieralisi@....com
Cc: linux-kernel@...r.kernel.org, linaro-acpi@...ts.linaro.org,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
linux-pci@...r.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Liviu.Dudau@....com, ddaney@...iumnetworks.com,
Narinder.Dhillon@...iumnetworks.com, linux-acpi@...r.kernel.org,
robert.richter@...iumnetworks.com, wangyijing@...wei.com,
tglx@...utronix.de, jiang.liu@...ux.intel.com,
linux-arm-kernel@...ts.infradead.org,
Stefano.Stabellini@...citrix.com
Subject: Re: [Linaro-acpi] [PATCH V1 07/11] XEN / PCI: Remove the dependence
on arch x86 when PCI_MMCONFIG=y
+ Stefano
On 27.10.2015 17:38, Tomasz Nowicki wrote:
> From: Hanjun Guo <hanjun.guo@...aro.org>
>
> In drivers/xen/pci.c, there are arch x86 dependent codes when
> CONFIG_PCI_MMCONFIG is enabled, since CONFIG_PCI_MMCONFIG
> depends on ACPI, so this will prevent XEN PCI running on other
> architectures using ACPI with PCI_MMCONFIG enabled (such as ARM64).
>
> Fortunatly, it can be sloved in a simple way. In drivers/xen/pci.c,
> the only x86 dependent code is if ((pci_probe & PCI_PROBE_MMCONF) == 0),
> and it's defined in asm/pci_x86.h, the code means that
> if the PCI resource is not probed in PCI_PROBE_MMCONF way, just
> ingnore the xen mcfg init. Actually this is duplicate, because
> if PCI resource is not probed in PCI_PROBE_MMCONF way, the
> pci_mmconfig_list will be empty, and the if (list_empty())
> after it will do the same job.
>
> So just remove the arch related code and the head file, this
> will be no functional change for x86, and also makes xen/pci.c
> usable for other architectures.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> ---
> drivers/xen/pci.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index 6785ebb..9a8dbe3 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -28,9 +28,6 @@
> #include <asm/xen/hypervisor.h>
> #include <asm/xen/hypercall.h>
> #include "../pci/pci.h"
> -#ifdef CONFIG_PCI_MMCONFIG
> -#include <asm/pci_x86.h>
> -#endif
>
> static bool __read_mostly pci_seg_supported = true;
>
> @@ -222,9 +219,6 @@ static int __init xen_mcfg_late(void)
> if (!xen_initial_domain())
> return 0;
>
> - if ((pci_probe & PCI_PROBE_MMCONF) == 0)
> - return 0;
> -
> if (list_empty(&pci_mmcfg_list))
> return 0;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists