linux-kernel - Re: [PATCH] scsi_sysfs: Fix queue_ramp_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562ED9E0.7050603@acm.org>
Date:	Mon, 26 Oct 2015 18:56:48 -0700
From:	Bart Van Assche <bvanassche@....org>
To:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

On 10/26/15 07:54, Peter Oberparleiter wrote:
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
> ---
>   drivers/scsi/scsi_sysfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
>   		return -EINVAL;
>
>   	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> -	return period;
> +	return count;
>   }
>
>   static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,

Hello Peter,

Good catch. But please CC the people who introduced this code and also 
"stable" (see also commit 4a84067dbfce436b81779e585bf712b02ceee552).

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/