linux-kernel - Re: [PATCH 03/15] tty: Deinline n_tty_receive_char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <562FBDBB.70500@hurleysoftware.com>
Date:	Tue, 27 Oct 2015 14:08:59 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>, linux-kernel@...r.kernel.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224
 bytes

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 198 bytes of machine code.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Peter Hurley <peter@...leysoftware.com>
> CC: Jiri Slaby <jslaby@...e.com>
> CC: linux-serial@...r.kernel.org
> ---
>  drivers/tty/n_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index b09023b..c38f5d8 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -1407,7 +1407,7 @@ handle_newline:
>  	return 0;
>  }
>  
> -static inline void
> +static void
>  n_tty_receive_char_inline(struct tty_struct *tty, unsigned char c)
>  {
>  	struct n_tty_data *ldata = tty->disc_data;
> 

This is one of the patches I will rework differently to remove the
inlining (n_tty_receive_char_inline() can be deleted and its call
sites replaced with n_tty_receive_char()).

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/