linux-kernel - Re: [PATCH] get_maintainer: Don't fallback to git by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1445970099.2757.22.camel@perches.com>
Date:	Tue, 27 Oct 2015 11:21:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Lee Jones <lee.jones@...aro.org>, Theodore Ts'o <tytso@....edu>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Laura Abbott <labbott@...hat.com>,
	linux-kernel@...r.kernel.org, linux-kernel-owner@...r.kernel.org
Subject: Re: [PATCH] get_maintainer: Don't fallback to git by default

On Tue, 2015-10-27 at 10:49 -0700, Joe Perches wrote:
> On Tue, 2015-10-27 at 11:29 +0100, Wolfram Sang wrote:
> > > act as reviewers, they should have a mention in MAINTAINERS for
> > > get_maintiner.pl to pull information from:
> > > 
> > > R: Designated reviewer: FullName <address@...ain>
> > >    These reviewers should be CCed on patches.
> > 
> > I think this should do.
> > 
> > Interested parties should start by scanning the mailing list :)
> 
> I think the concept of reviewers is fine.
> 
> A couple weeks ago, I suggested a mechanism to have reviewers
> concentrate their entries into separate REVIEWERS file(s)
> 
> https://lkml.org/lkml/2015/10/16/649
> 
> These REVIEWERS* files would also work for companies that have
> people with specific areas of expertise that want internal review
> before public exposure.
> 
> Kconfig and Makefile files in directories like drivers/i2c/busses
> are outliers because all new individual drivers are added to both
> files.
> 
> The mechanism to limit git-fallback use is a directory depth match.
> 
> Wolfram has a MAINTAINERS entry of:
> 	F:	drivers/i2c/
> but that doesn't pattern doesn't match the directory depth of
> file drivers/i2c/busses/Kconfig so git-fallback is used for files
> that don't have specific MAINTAINERS.
> 
> It _might_ make some sense to limit activation of git history in
> that specific case, but for some path like arch/, that limitation
> might _not_ make sense.

Another option would be to add another pattern to the
I2C section that matches all subdirectories of drivers/i2c/:
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index fb7d2e4..c670e1f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5104,6 +5104,7 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/i2c/
 F:	Documentation/i2c/
 F:	drivers/i2c/
+F:	drivers/i2c/*/
 F:	include/linux/i2c.h
 F:	include/linux/i2c-*.h
 F:	include/uapi/linux/i2c.h




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/