linux-kernel - Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2015 11:52:05 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	ygardi@...eaurora.org
Cc:	robherring2@...il.com, james.bottomley@...senpartnership.com,
	pebolle@...cali.nl, hch@...radead.org,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	gbroner@...eaurora.org, draviv@...eaurora.org,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...n.com>
Subject: Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings

On 10/27/2015 11:22 AM, ygardi@...eaurora.org wrote:
>> On 10/27/2015 03:10 AM, ygardi@...eaurora.org wrote:
>>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>>>>> Tnis patch fixes the following compilation warnings:
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	expected void const *ptr
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	expected void const *ptr
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>>
>>>>> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>
>>>>>
>>>>> ---
>>>> What version of sparse do you use? You shouldn't need to do this.
>>>>
>>> i just updated my sparse to the newest -
>>> so i'm using sparse 0.4.4
>>> and the command i use is:
>>> make ARCH=arm C=1  CF="-Wsparse-all"
>>> and i still get all the warnings.
>>> with my patch, the are no warnings.
>>>
>> That is not the latest version of sparse. I'm not sure when sparse was
>> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db
>>
> Stephen, is this something you insist on?
> i think the patch can stay as it is.
> please let me know, as i wouldn't like this issue to block the entire patch
>

Yes. Adding __force is wrong. Just drop this patch.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/