linux-kernel - Re: [PATCH] kernel: power: replacing printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1445972443.2757.34.camel@perches.com>
Date:	Tue, 27 Oct 2015 12:00:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	rjw@...ysocki.net, pavel@....cz, len.brown@...el.com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: power: replacing printk

On Tue, 2015-10-27 at 09:46 +0530, Saurabh Sengar wrote:
> replacing prink(s) with appropriate pr_info and pr_err
[]
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
[]
> @@ -486,9 +486,9 @@ static int enter_state(suspend_state_t state)
>  
>  #ifndef CONFIG_SUSPEND_SKIP_SYNC
>  	trace_suspend_resume(TPS("sync_filesystems"), 0, true);
> -	printk(KERN_INFO "PM: Syncing filesystems ... ");
> +	pr_info("PM: Syncing filesystems ... ");
>  	sys_sync();
> -	printk("done.\n");
> +	pr_info("done.\n");
>  	trace_suspend_resume(TPS("sync_filesystems"), 0, false);
>  #endif
>  

This isn't the same output.

The original code emits on a single line.

This new code emits on two lines, the second
line without a "PM: " prefix.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/