linux-kernel - Re: [PATCH 1/6] block: Remove unneeded variable err for returning 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 00:41:28 +0530
From:	punit vara <punitvara@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	drbd-user@...ts.linbit.com, drbd-dev@...ts.linbit.com,
	Punit Vara <punitvara@...il.com>
Subject: Re: [PATCH 1/6] block: Remove unneeded variable err for returning 0

On Mon, Oct 26, 2015 at 12:18 AM, Punit Vara <punitvara@...il.com> wrote:
> This patch is to the mg_disk.c file that removes unnecessary err
> and fixes  following warning reported by coccicheck:
>
> Unneeded variable: "err". Return "0" on line 1077
>
> Signed-off-by: Punit Vara <punitvara@...il.com>
> ---
>  drivers/block/mg_disk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
> index 145ce2a..d6f3feb 100644
> --- a/drivers/block/mg_disk.c
> +++ b/drivers/block/mg_disk.c
> @@ -1038,7 +1038,6 @@ static int mg_remove(struct platform_device *plat_dev)
>  {
>         struct mg_drv_data *prv_data = plat_dev->dev.platform_data;
>         struct mg_host *host = prv_data->host;
> -       int err = 0;
>
>         /* delete timer */
>         del_timer_sync(&host->timer);
> @@ -1074,7 +1073,7 @@ static int mg_remove(struct platform_device *plat_dev)
>         /* free mg_host */
>         kfree(host);
>
> -       return err;
> +       return 0;
>  }
>
>  static struct platform_driver mg_disk_driver = {
> --
> 2.5.3
>
Anybody going to review this patches please and I dont know who is
maintainer for all these patches
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/