| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <562FD22D.2030206@nod.at> Date: Tue, 27 Oct 2015 20:36:13 +0100 From: Richard Weinberger <richard@....at> To: Saurabh Sengar <saurabh.truth@...il.com> Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, "Rafael J. Wysocki" <rjw@...ysocki.net> Subject: Re: [PATCH v2] PM / suspend: replacing printk Am 27.10.2015 um 20:32 schrieb Saurabh Sengar: > it fixes the checkpatch.pl <http://checkpatch.pl> warnings Don't get me wrong, but checkpatch.pl is only a script which makes suggestions. Especially as these are only warnings and not errors. IMHO the code is perfectly fine as is. Thanks, //richard > On Oct 28, 2015 12:56 AM, "Richard Weinberger" <richard.weinberger@...il.com <mailto:richard.weinberger@...il.com>> wrote: >> >> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar <saurabh.truth@...il.com <mailto:saurabh.truth@...il.com>> wrote: >> > replacing prink(s) with appropriate pr_info and pr_err >> > >> > Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com <mailto:saurabh.truth@...il.com>> >> > --- >> > kernel/power/suspend.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> >> In which way does this patch improve the existing code? >> You describe what it does but not which problem it solves and >> why this patch is necessary. >> >> -- >> Thanks, >> //richard > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists