linux-kernel - Re: [PATCH] ACPI/PAD: power_saving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2245965.qHtce5ZjLr@vostro.rjw.lan>
Date:	Wed, 28 Oct 2015 04:18:52 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] ACPI/PAD: power_saving_thread() is not freezable

On Monday, October 26, 2015 04:02:01 AM Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
> 
> power_saving_thread() calls try_to_freeze(), but the thread doesn't mark
> itself freezable through set_freezable(), so the try_to_freeze()
> call is useless.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> ---
>  drivers/acpi/acpi_pad.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
> index ae307ff..8ea8211 100644
> --- a/drivers/acpi/acpi_pad.c
> +++ b/drivers/acpi/acpi_pad.c
> @@ -148,8 +148,6 @@ static int power_saving_thread(void *data)
>  	while (!kthread_should_stop()) {
>  		unsigned long expire_time;
>  
> -		try_to_freeze();
> -
>  		/* round robin to cpus */
>  		expire_time = last_jiffies + round_robin_time * HZ;
>  		if (time_before(expire_time, jiffies)) {
> 

Applied, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/