[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOesGMgdX4TXwN7psHCHVoJ=BGnZQUp_0UWTK6n-tH3wUcWykw@mail.gmail.com>
Date: Wed, 28 Oct 2015 16:07:25 +0900
From: Olof Johansson <olof@...om.net>
To: Darren Hart <dvhart@...radead.org>
Cc: Michal Marek <mmarek@...e.com>,
"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH 07/10] merge_config.sh: add tests
On Wed, Oct 28, 2015 at 4:00 PM, Darren Hart <dvhart@...radead.org> wrote:
> On Wed, Oct 28, 2015 at 09:42:08AM +0900, Olof Johansson wrote:
>> For being a small script, merge_config.sh is fairly scary to change since there's no
>> real way to know if you did something wrong. So it seems appropriate to add a simple
>> test suite.
>>
>> I've started with testcases in the areas I care about, other should of course feel
>> free to expand on this.
>>
>> Use is simple, from the kernel tree, run ./scripts/kconfig/merge_config_test/runall.
>> It'll execute out of a tmpdir under /tmp.
>>
>> Signed-off-by: Olof Johansson <olof@...om.net>
>
> Thanks for writing the test cases. Shell scripting is so easy to bikeshed - so
> I'm going to skip that. I didn't catch any bashisms, and the test coverage is
> good.
Thanks!
Anyone who wishes to contribute style comments has to contribute at
least one additional testcase as well. Fair? :)
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists