linux-kernel - Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151028100951.GG28572@localhost>
Date:	Wed, 28 Oct 2015 11:09:51 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Michal Marek <mmarek@...e.com>
Cc:	Johan Hovold <johan@...nel.org>,
	Julia Lawall <julia.lawall@...6.fr>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	linux-kernel@...r.kernel.org, cocci@...teme.lip6.fr
Subject: Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

On Wed, Oct 28, 2015 at 11:04:56AM +0100, Michal Marek wrote:
> Dne 28.10.2015 v 10:54 Johan Hovold napsal(a):
> > On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote:
> >> Should have acked this message...
> >>
> >> Acked-by: Julia Lawall <julia.lawall@...6.fr>
> >>
> >> On Wed, 30 Sep 2015, Johan Hovold wrote:
> >>
> >>> This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch
> >>> to delete overly complex return code processing").
> >>>
> >>> There can be both symmetry and readability reasons for not wanting to do
> >>> the final function call as part of the return statement and to maintain
> >>> a clear separation of success and error paths.
> >>>
> >>> Since this is in no way mandated by the coding standard, let's just
> >>> remove this semantic patch to avoid having "clean up" patches being
> >>> posted over and over in response to these Coccinelle warnings.
> >>>
> >>> Signed-off-by: Johan Hovold <johan@...nel.org>
> > 
> > Is anyone planning on picking this patch up?
> 
> It is already in kbuild.git as commit 1a617a8475e8, I apparenly forgot
> to reply to this thread.

Ok, great.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/