lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151028010443.GX28319@sirena.org.uk>
Date: Wed, 28 Oct 2015 10:04:43 +0900
From: Mark Brown <broonie@...nel.org>
To: Damien Horsley <Damien.Horsley@...tec.com>
Cc: alsa-devel@...a-project.org,
James Hartley <James.Hartley@...tec.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH V2 02/10] ASoC: img: Add driver for I2S
input controller
On Tue, Oct 27, 2015 at 01:55:27PM +0000, Damien Horsley wrote:
> On 23/10/15 23:57, Mark Brown wrote:
> > Shouldn't we be doing that flush on stream close instead? If nothing
> > else the flush is going to discard a bit of data if the stream is just
> > paused.
> The FIFOs are only 8 frames in size, so I am not sure there is an
> issue with these frames being lost.
> I think it also makes sense to keep the blocks consistent with each
> other. The spdif (out and in), and parallel out, all flush automatically
> when stopped, and the fifo for the i2s out block is cleared when the
> reset is asserted.
This seems like an issue that got missed in the other drivers then. I'd
expect the trigger operation to be a minimal operation which starts and
stops the data transfer, not doing anything else.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists