linux-kernel - Re: [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5630D16A.1020604@hurleysoftware.com>
Date:	Wed, 28 Oct 2015 09:45:14 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than
 SERIAL_IO_MEM

Hi Saurabh,

On 10/27/2015 03:46 AM, Saurabh Sengar wrote:
> use UPIO_MEM rather then SERIAL_IO_MEM.
> both have the same value
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
> ---
>  drivers/tty/serial/sa1100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c
> index fd3d132..283c7e0 100644
> --- a/drivers/tty/serial/sa1100.c
> +++ b/drivers/tty/serial/sa1100.c
> @@ -579,7 +579,7 @@ sa1100_verify_port(struct uart_port *port, struct serial_struct *ser)
>  		ret = -EINVAL;
>  	if (sport->port.irq != ser->irq)
>  		ret = -EINVAL;
> -	if (ser->io_type != SERIAL_IO_MEM)
> +	if (ser->io_type != UPIO_MEM)

SERIAL_IO_* io_type defines are the appropriate constants for the
struct serial_struct::io_type field. Both are defined in the
uapi header, include/uapi/linux/serial.h

UPIO_* io_type defines are the appropriate constants for the
struct uart_port::io_type field. Both are defined in the kernel
header, include/kernel/serial_core.h

I defined the UPIO_* io_types in terms of SERIAL_IO_* because
userspace breakage was occurring as contributors were changing
the UPIO_* constant values.


Regards,
Peter Hurley


>  		ret = -EINVAL;
>  	if (sport->port.uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/