linux-kernel - Re: [PATCH 3.12 009/123] USB: usbtmc: add device quirk for Rigol DS6104

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHK3XzjCOeJhW61BViYiP=f7g42kVf9JX2tzMDYJhMNSP0yy7A@mail.gmail.com>
Date:	Wed, 28 Oct 2015 16:33:01 +0100
From:	Teunis van Beelen <teuniz@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3.12 009/123] USB: usbtmc: add device quirk for Rigol DS6104

Recently there was a firmware update for the Rigol DS6000 series that
seems to solve the need for the "Rigol quirk".
After a quick check, it looks like the scope now works well with and
without the patch.
I need to do some more testing though...
What do you suggest, we put it on hold, we wait?
How much time do we have? Let me know.

Kind Regards,

Teunis van Beelen



On Wed, Oct 28, 2015 at 2:50 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> From: Teunis van Beelen <teuniz@...il.com>
>
> 3.12-stable review patch.  If anyone has any objections, please let me know.
>
> ===============
>
> commit f50420223071b6ff4b586308f5c27eec54694a81 upstream.
>
> Recently we purchased the Rigol DS6104 and when I try to operate it from
> my Linux pc, everything works well with the default usbtmc driver,
> except when I want to download a big datachunk like a screenshot. This
> bitmapfile has a size of 1152054 bytes but I receive a smaller file and
> no new packets can be read.
>
> When I took a look at the driver source, I found this "Rigol quirk" and
> I added the id of the new DS series oscilloscopes to this list. I
> compiled it and loaded the new driver and now everything seems to work
> fine.
>
> Signed-off-by: Teunis van Beelen <teuniz@...il.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> ---
>  drivers/usb/class/usbtmc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
> index 09de131ee0cb..c997ee9122bc 100644
> --- a/drivers/usb/class/usbtmc.c
> +++ b/drivers/usb/class/usbtmc.c
> @@ -110,6 +110,7 @@ struct usbtmc_ID_rigol_quirk {
>
>  static const struct usbtmc_ID_rigol_quirk usbtmc_id_quirk[] = {
>         { 0x1ab1, 0x0588 },
> +       { 0x1ab1, 0x04b0 },
>         { 0, 0 }
>  };
>
> --
> 2.6.2
>



-- 
"C'è qualcosa nella nebbia! Qualcosa nella nebbia ha preso John Lee!"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/