lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPcyv4ggrX0QGELcBt-Vu_xh6mtFvxMTiMsKYfKf4z72O73JVg@mail.gmail.com> Date: Wed, 28 Oct 2015 11:06:41 +0900 From: Dan Williams <dan.j.williams@...el.com> To: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Cc: Russell King <rmk+kernel@....linux.org.uk>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ard Biesheuvel <ard.biesheuvel@...aro.org> Subject: Re: [for 4.4 PATCH] memremap: fix highmem support On Wed, Oct 28, 2015 at 10:39 AM, Dan Williams <dan.j.williams@...el.com> wrote: > Currently memremap checks if the range is "System RAM" and returns the > kernel linear address. This is broken for highmem platforms where a > range may be "System RAM", but is not part of the kernel linear mapping. > Similar to acpi_map(), use kmap() for PAGE_SIZE memremap() requests for > highmem, and fall back to ioremap_cache() otherwise. > > The impact of this bug is low for now since the pmem driver is the only > user of memremap(), but this is important to fix before more conversions > to memremap arrive in 4.4. > > Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com> > Cc: Russell King <rmk+kernel@....linux.org.uk> > Reported-by: Ard Biesheuvel <ard.biesheuvel@...aro.org> > Signed-off-by: Dan Williams <dan.j.williams@...el.com> > --- > Russell, > > I question whether the kmap fallback is needed. This is borrowed from > the current implementation of acpi_map(), and I added it since arm > ioremap warns if passed pfn_valid() addresses. I flubbed the subject line... this is for 4.3-final. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists