| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Oct 2015 08:19:23 +0100 From: Johan Hovold <johan@...nel.org> To: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com> Cc: johan@...nel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug On Wed, Oct 28, 2015 at 09:51:26AM +0100, Johan Hovold wrote: > On Tue, Oct 27, 2015 at 04:53:34PM -0500, Konstantin Shkolnyy wrote: > > cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped. > > However, SET_LINE_CTL functions properly. When the driver tries to modify > > the register, it reads it, modifies some bits and writes back. Because the > > read bytes were swapped, this often results in an invalid value to be > > written. In turn, this causes cp2108 respond with a stall. The stall > > sometimes doesn't clear properly and cp2108 starts responding to following > > valid commands also with stalls, effectively failing. > > > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com> > I gave the series a really quick test on an cp2102-device I had lying > around. I assume you verified the changes on some other older devices as > well? Did you test this series on the older device types as well? Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists