linux-kernel - Re: [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151029082512.GD8367@shlinux2>
Date:	Thu, 29 Oct 2015 16:25:13 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	Nathan Sullivan <nathan.sullivan@...com>
CC:	<gregkh@...uxfoundation.org>, <balbi@...com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3] usb: remove unnecessary CONFIG_PM dependency from
 USB_OTG

On Wed, Oct 28, 2015 at 08:41:41AM -0500, Nathan Sullivan wrote:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
> 
> Remove the unneeded "default n" from USB_OTG as well, the default is
> already n.

I prefer not to remove it, since most of people may not want to
enable it, you can grep the Kconfig in the kernel source, there
are lots of "default n", especially, it can indicate people that
if they are not sure, set 'n' for it.

Peter

> 
> Tested on Bay Trail hardware with dwc3 USB.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> ---
>  drivers/usb/core/Kconfig |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..567454f 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,8 +43,6 @@ config USB_DYNAMIC_MINORS
>  
>  config USB_OTG
>  	bool "OTG support"
> -	depends on PM
> -	default n
>  	help
>  	  The most notable feature of USB OTG is support for a
>  	  "Dual-Role" device, which can act as either a device
> -- 

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/