linux-kernel - Re: [PATCH] scripts: checkpatch: remove preceding dot-slash from path name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1446126406.2757.160.camel@perches.com>
Date:	Thu, 29 Oct 2015 06:46:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	Christian Gromm <christian.gromm@...rochip.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: checkpatch: remove preceding dot-slash from
 path name

On Thu, 2015-10-29 at 14:06 +0100, Christian Gromm wrote:
> In case checkpatch is called with a path name that starts with ./ for
> the current directory not all issues are being reported since internal
> path checks don't succeed. This patch removes the leading './' from
> $filename. This is needed to have checkpatch report all issues found
> during execution.
> 
> Signed-off-by: Christian Gromm <christian.gromm@...rochip.com>
> ---
>  scripts/checkpatch.pl |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f2a1131..44435fd 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -730,6 +730,9 @@ my $fixlinenr = -1;
>  my $vname;
>  for my $filename (@ARGV) {
>  	my $FILE;
> +	if ($filename =~ /^(\.\/)/) {
> +		substr($filename, 0, 2) = "";
> +	}

If you are going to attempt to do pathname translations,
please do it comprehensively using something like realpath.

$ cd <linux source tree path>
$ cd drivers/staging
$ <path if necessary>checkpatch.pl -f ./<file>

And it should be done for the files contained
in a patch too.

thanks.

>  	if ($file) {
>  		open($FILE, '-|', "diff -u /dev/null $filename") ||
>  			die "$P: $filename: diff failed - $!\n";



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/