linux-kernel - Re: [PATCH] audit: removing unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Oct 2015 10:06:14 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Saurabh Sengar <saurabh.truth@...il.com>,
	Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: removing unused variable

On Wed, Oct 28, 2015 at 6:12 PM, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
>> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
>> > variavle rc in not required as it is just used for unchanged for return,
>> > and return is always 0 in the function.
> []
>> Thanks, applied with some spelling corrections to the description.
>
> As the return value is never actually tested,
> it seems better to make it a void function,

Agreed, I did just that yesterday.

 * https://www.redhat.com/archives/linux-audit/2015-October/msg00125.html

-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/