linux-kernel - Re: [PATCH V6 2/3] Add reset controller for hi6220 SoC platform.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1446135292.3274.67.camel@pengutronix.de>
Date:	Thu, 29 Oct 2015 17:14:52 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	linux-kernel@...r.kernel.org, puck.chen@...yun.com,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk
Subject: Re: [PATCH V6 2/3] Add reset controller for hi6220 SoC platform.

Am Donnerstag, den 29.10.2015, 20:55 +0800 schrieb Chen Feng:
> reset: add driver for hi6220 reset controller

Same comment as for patch 1, this should probably be the subject,
the commit message body was better in V4.

> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> ---
>  drivers/reset/Kconfig                          |   1 +
>  drivers/reset/Makefile                         |   1 +
>  drivers/reset/hisilicon/Kconfig                |   5 ++
>  drivers/reset/hisilicon/Makefile               |   1 +
>  drivers/reset/hisilicon/hi6220_reset.c         | 108 +++++++++++++++++++++++++
>  include/dt-bindings/reset/hisi,hi6220-resets.h |  67 +++++++++++++++

Move the header file into patch 1, it is better to include this with the
binding documentation.

regards
Philipp


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/