| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1446136250-11507-3-git-send-email-vkuznets@redhat.com> Date: Thu, 29 Oct 2015 17:30:48 +0100 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Ulf Hansson <ulf.hansson@...aro.org>, James Bottomley <JBottomley@...n.com>, Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org Subject: [PATCH v3 2/4] lib/string_helpers.c: protect string_get_size() against blk_size=0 Division by zero happens if blk_size=0 is supplied to string_get_size(). Add WARN_ON() and set size to 0 to report '0 B'. Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com> --- lib/string_helpers.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/string_helpers.c b/lib/string_helpers.c index f6c27dc..ff3575b 100644 --- a/lib/string_helpers.c +++ b/lib/string_helpers.c @@ -50,6 +50,11 @@ void string_get_size(u64 size, u32 blk_size, const enum string_size_units units, tmp[0] = '\0'; i = 0; + + /* Calling string_get_size() with blk_size=0 is wrong! */ + if (WARN_ON(!blk_size)) + size = 0; + if (!size) goto out; -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists