linux-kernel - Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1446142447.14635.13.camel@schen9-desk2.jf.intel.com>
Date:	Thu, 29 Oct 2015 11:14:07 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Stephan Mueller <smueller@...onox.de>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"H. Peter Anvin" <hpa@...or.com>,
	"David S.Miller" <davem@...emloft.net>,
	Chandramouli Narayanan <mouli_7982@...oo.com>,
	Vinodh Gopal <vinodh.gopal@...el.com>,
	James Guilford <james.guilford@...el.com>,
	Wajdi Feghali <wajdi.k.feghali@...el.com>,
	Jussi Kivilinna <jussi.kivilinna@....fi>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code

On Thu, 2015-10-29 at 09:19 -0700, Tim Chen wrote:
> On Thu, 2015-10-29 at 03:03 +0100, Stephan Mueller wrote:
> > Am Mittwoch, 28. Oktober 2015, 14:19:29 schrieb Tim Chen:
> > 
> > Hi Tim,
> > 
> > >+
> > >+	/* check for dependent cpu features */
> > >+	if (!cpu_has_aes) {
> > >+		pr_err("aes_cbc_mb_mod_init: no aes support\n");
> > >+		err = -ENODEV;
> > >+		goto err1;
> > >+	}
> > 
> > In your post 0/5, you say that this mechanism needs AVX2. In the existing 
> > AESNI glue code I find
> > 
> > #ifdef CONFIG_X86_64
> > #ifdef CONFIG_AS_AVX2
> >         if (boot_cpu_has(X86_FEATURE_AVX2)) {
> > 
> > ...
> > 
> > Why would that CPU check not be needed here?
> 
> Good catch.  Will add check for avx2.

Actually since we are using only XMM registers and SSE instructions,
checking for SSE support will be sufficient.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/