linux-kernel - Re: [PATCH v2] blktrace: re-write setting q->blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Oct 2015 16:52:55 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Davidlohr Bueso <dave@...olabs.net>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] blktrace: re-write setting q->blk_trace

Jens Axboe <axboe@...nel.dk> writes:

> On 10/30/2015 05:46 AM, Jeff Moyer wrote:
>> Jens Axboe <axboe@...nel.dk> writes:
>>
>>> On 10/30/2015 04:19 AM, Davidlohr Bueso wrote:
>>>>
>>>>> The patch itself looks ok, but it doesn't seem to apply to a recent
>>>>> kernel tree.  It appears as though it is white-space damaged.  Would you
>>>>> mind re-sending it?
>>>>
>>>> Hmm sorry about that. I thought I had based it against that day's
>>>> tip/master.
>>>> Anyway, here is v3 which is against tip/master as of
>>>> 338e29ba93639138fafb9fb5ba946fd99a512aae.
>>>
>>> Thanks, this is definitely cleaner. Your patch is still pretty
>>> mangled, though. I had to hand apply it. Please check the result:
>>
>> Heh, and here I just assumed the problem was on my end.
>>
>>> http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8
>>
>> That looks fine, except you're missing the 'R' in Reviewed-by.
>
> e-viewed. Electronically viewed by jeff?

Heh.  Well, that's not wrong!  ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/