lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151029045931.GA17127@roeck-us.net> Date: Wed, 28 Oct 2015 21:59:31 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Sudeep Holla <sudeep.holla@....com> Cc: linux-kernel@...r.kernel.org, Punit Agrawal <punit.agrawal@....com>, lm-sensors@...sensors.org, Jean Delvare <jdelvare@...e.com> Subject: Re: [PATCH v2] hwmon: (scpi) skip unsupported sensors properly On Wed, Oct 28, 2015 at 05:17:31PM +0000, Sudeep Holla wrote: > Currently it's assumed that firmware exports only the class of sensors > supported by the driver. However with newer firmware or SCPI protocol > revision, support for newer classes of sensors can be present. > > The driver fails to probe with the following warning if an unsupported > class of sensor is encountered in the firmware. > > sysfs: cannot create duplicate filename > '/devices/platform/scpi/scpi:sensors/hwmon/hwmon0/' > ------------[ cut here ]------------ > WARNING: at fs/sysfs/dir.c:31 > Modules linked in: > > CPU: 0 PID: 6 Comm: kworker/u12:0 Not tainted 4.3.0-rc7 #137 > Hardware name: ARM Juno development board (r0) (DT) > Workqueue: deferwq deferred_probe_work_func > PC is at sysfs_warn_dup+0x54/0x78 > LR is at sysfs_warn_dup+0x54/0x78 > > This patch fixes the above issue by skipping through the unsupported > class of SCPI sensors. > > Fixes: 68acc77a2d51 ("hwmon: Support thermal zones registration for SCP temperature sensors") > Fixes: ea98b29a05e9 ("hwmon: Support sensors exported via ARM SCP interface") > Cc: Guenter Roeck <linux@...ck-us.net> > Reviewed-by: Punit Agrawal <punit.agrawal@....com> > Signed-off-by: Sudeep Holla <sudeep.holla@....com> Acked-by: Guenter Roeck <linux@...ck-us.net> > --- > drivers/hwmon/scpi-hwmon.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > Hi Guenter, > > Either me/Punit will need ping you once the original driver is merged > via arm-soc so that you can pick this after that. Alternatively we > can push it via arm-soc but I wouldn't rush for that as it's not that > urgent. Is that fine with you ? > Either way is fine with me. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists