linux-kernel - RE: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling device registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE6402866099C@shsmsx102.ccr.corp.intel.com>
Date:	Fri, 30 Oct 2015 08:21:40 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Javi Merino <javi.merino@....com>
CC:	"Zhang, Rui" <rui.zhang@...el.com>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling
 device registered

Hi, Javi,
thanks for your review,
will send a version 3 out soon.

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@....com]
> Sent: Wednesday, October 28, 2015 6:40 PM
> To: Chen, Yu C
> Cc: Zhang, Rui; edubezval@...il.com; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: Re: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling
> device registered
> 
> Hi Yu,
> 
> One minor nit below.  Other than that you can add my
> 
> Reviewed-by: Javi Merino <javi.merino@....com>
> 
> On Mon, Oct 26, 2015 at 11:15:30AM +0800, Chen Yu wrote:
> > When a new cooling device is registered, we need to update the thermal
> > zone to set the new registered cooling device to a proper state.
> >
> > This fixes a problem that the system is cool, while the fan devices
> > are left running on full speed after boot, if fan device is registered
> > after thermal zone device.
> >
> > Here is the history of why current patch looks like this:
> > https://patchwork.kernel.org/patch/7273041/
> >
> > CC: <stable@...r.kernel.org> #3.18+
> > Reference:https://bugzilla.kernel.org/show_bug.cgi?id=92431
> > Tested-by: Manuel Krause <manuelkrause@...scape.net>
> > Tested-by: szegad <szegadlo@...zta.onet.pl>
> > Tested-by: prash <prash.n.rao@...il.com>
> > Tested-by: amish <ammdispose-arch@...oo.com>
> > Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> > Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> > ---
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h index
> > 5bcabc7..4298418 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -195,6 +195,7 @@ struct thermal_zone_device {
> >  	int emul_temperature;
> >  	int passive;
> >  	unsigned int forced_passive;
> > +	atomic_t need_update;
> 
> Please document this field in the kernel-doc comment for struct
> thermal_zone_device.
> 

Best Regards,
Yu