linux-kernel - Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1446195000.16404.55.camel@suse.de>
Date:	Fri, 30 Oct 2015 09:50:00 +0100
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Tina Ruchandani <ruchandani.tina@...il.com>,
	linux-scsi@...r.kernel.org, arnd@...db.de
Cc:	"James E.J. Bottomley" <JBottomley@...n.com>,
	y2038@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

Hi,

On Fri, 2015-10-30 at 01:30 -0700, Tina Ruchandani wrote:
> Function stex_gettime uses 'struct timeval' whose tv_sec value
> will overflow on 32-bit systems in year 2038 and beyond. This patch
> replaces the use of struct timeval and do_gettimeofday with
> ktime_get_real_seconds, which returns a 64-bit seconds value.

Thanks for the conversion. Can you please check if other (scsi) drivers
have the same y2038 issues? A quick "git grep do_gettimeofday
drivers/scsi/  | wc -l" reveals 30 occurrences (of cause not all are
problematic).


Other than that
Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/