linux-kernel - Re: [PATCH -next] sparc: Populate 'device' for platform device devicetree nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151030.181023.877331632514498887.davem@davemloft.net>
Date:	Fri, 30 Oct 2015 18:10:23 +0900 (KST)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
	tomeu.vizoso@...labora.com
Subject: Re: [PATCH -next] sparc: Populate 'device' for platform device
 devicetree nodes

From: Guenter Roeck <linux@...ck-us.net>
Date: Sun, 25 Oct 2015 17:26:38 -0700

> Since commit 61e82530d80f ("of/platform: Point to struct device from device
> node"), the 'device' pointer in devicetree nodes for platform devices must
> be set for of_find_device_by_node to succeed. This is not the case unless
> the platform device was created using of_platform_device_create(), which
> is not always the case. This causes all sparc images to crash with "Unable
> to handle NULL pointer reference" in functions such as iommu_init(), which
> don't expect of_find_device_by_node() to return NULL.
> 
> Cc: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> This patch depends on the patch causing the problem (which can not be easily
> reverted). It should probably go through the same tree as that patch,
> or the patches should be merged.

Indeed, please merge this into the tree that added the change in
question:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/