linux-kernel - Re: [PATCH -rt] Revert "net: use synchronize_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151030.181608.1502431720880609527.davem@davemloft.net>
Date:	Fri, 30 Oct 2015 18:16:08 +0900 (KST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	joshc@...com, paulmck@...ux.vnet.ibm.com, tglx@...utronix.de,
	bigeasy@...utronix.de, linux-rt-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()"

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 27 Oct 2015 07:18:01 -0700

> On Tue, 2015-10-27 at 07:31 -0500, Josh Cartwright wrote:
> 
>> Okay, yes, I like the first suggestion better as well, I've included a
>> patch below that does just that.  I hope you don't mind me turning it
>> into a Suggested-by :).
>> 
>> Thanks for taking a look!
>>   Josh
> 
> 
>> @@ -6969,7 +6969,7 @@ EXPORT_SYMBOL(free_netdev);
>>  void synchronize_net(void)
>>  {
>>  	might_sleep();
>> -	if (rtnl_is_locked())
>> +	if (rtnl_is_locked() && !IS_ENABLED(CONFIG_PREEMPT_RT_FULL))
>>  		synchronize_rcu_expedited();
>>  	else
>>  		synchronize_rcu();
> 
> No objection from me. Thanks.
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

I agree with the sentiment to do the simple thing here first before
adding potentially useless knobs.

Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/