linux-kernel - [tip:irq/core] Document that IRQ_NONE should be returned when IRQ not actually handled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1@git.kernel.org>
Date:	Fri, 30 Oct 2015 02:18:41 -0700
From:	tip-bot for David Woodhouse <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	dwmw2@...radead.org, hpa@...or.com, mingo@...nel.org,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	David.Woodhouse@...el.com
Subject: [tip:irq/core]
  Document that IRQ_NONE should be returned when IRQ not actually handled

Commit-ID:  d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1
Gitweb:     http://git.kernel.org/tip/d9e4ad5badf4ccbfddee208c898fb8fd0c8836b1
Author:     David Woodhouse <dwmw2@...radead.org>
AuthorDate: Wed, 28 Oct 2015 16:14:31 +0900
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 30 Oct 2015 10:13:26 +0100

Document that IRQ_NONE should be returned when IRQ not actually handled

Our IRQ storm detection works when an interrupt handler returns
IRQ_NONE for thousands of consecutive interrupts in a second. It
doesn't hurt to occasionally return IRQ_NONE when the interrupt is
actually genuine.

Drivers should only be returning IRQ_HANDLED if they have actually
*done* something to stop an interrupt from happening — it doesn't just
mean "this really *was* my device".

Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>
Cc: davem@...emloft.net
Link: http://lkml.kernel.org/r/1446016471.3405.201.camel@infradead.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 include/linux/irqreturn.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/irqreturn.h b/include/linux/irqreturn.h
index e374e36..eb1bdcf 100644
--- a/include/linux/irqreturn.h
+++ b/include/linux/irqreturn.h
@@ -3,7 +3,7 @@
 
 /**
  * enum irqreturn
- * @IRQ_NONE		interrupt was not from this device
+ * @IRQ_NONE		interrupt was not from this device or was not handled
  * @IRQ_HANDLED		interrupt was handled by this device
  * @IRQ_WAKE_THREAD	handler requests to wake the handler thread
  */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/